Fixed - IconSwitch - different background color to indicate checked/unchecked

[goguul]

Showing different background color using fill prop is existing functionality. Fixed where it has been removed.

Useful when same Icon is used for both checked/unchecked.

Currently fill prop is used in Saved Views (IncludeScopeToggleButton). This change is needed for S-59565 (Milestone Toggle in Roadmapping).

[kmmarsh]

This might be a good opportunity to remove the sliding hover on this switch that has been removed in the rest of Core

[goguul]

This might be a good opportunity to remove the sliding hover on this switch that has been removed in the rest of Core

Removed the sliding hover on IconSwitch and IconButton

[walkerrandolphsmith]

Please include the relevant information contained here https://paper.dropbox.com/doc/Toggle-Behavior--A3pQUObTqVMJewSmAvm_X5xFAg-gPTJvQKRj2NfporZ6wI2k in the README. If that information is no longer accurate then a designer can indicate that it is stale in their review. Thanks!

[walkerrandolphsmith]

It looks like this pr does not violate those design decisions made by @faudau but the mockups do. I think we should keep that in mind when moving forward with S-59565.

[mhh]

@walkerrandolphsmith can you clarify what you mean? the Icon toggle section says: "We represent the toggle with icons that can be empty (off) / filled (on)". To me, it looks like this change and the mockups for S-59565 adhere to that.

[goguul]

@walkerrandolphsmith Thanks for your feedback. We had discussion with @jerryo regarding this change. He added a comment in https://paper.dropbox.com/doc/Toggle-Behavior--A3pQUObTqVMJewSmAvm_X5xFAg-gPTJvQKRj2NfporZ6wI2k

From Jerry's point of view, the design doc didn't clearly mention what “filled” and “empty” is. Whether it means to fill the icon container background like in this PR or fill the Icon (like saved views favorite icon filled-star.svg)

We decided to go with existing approach to have two different Icons milestone.svg & filled-milestone.svg (not available currently need to create).

Please provide your suggestion.

If Icon with different background color is not needed, I can modify the code change in this PR to remove the fill prop in IconSwitch

[walkerrandolphsmith]

The decision that was attempted to be captured in the docs was that the icon itself would be filled and not the button. This is demonstrated in the SavedViews feature which prompted the documentation to be written.