GPU Aggregation (3/8): CPUAggregator #8888
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pessimistress
force-pushed
the
x/aggregation-2
branch
from
2362a0d
to
430a347
Compare
Pessimistress
force-pushed
the
x/aggregation-3
branch
2 times, most recently
from
bf5e17e
to
795f733
Compare
Pessimistress
force-pushed
the
x/aggregation-3
branch
from
795f733
to
78cfdbc
Compare
ibgreen
reviewed
May 14, 2024
| import {VertexAccessor, evaluateVertexAccessor} from './vertex-accessor'; | ||
|
|
||
| /** Settings used to construct a new CPUAggregator */ | ||
| export type CPUAggregatorSettings = { |
There was a problem hiding this comment.
This mix of ...Settings and ...Props here kind of trips me up.
- Can it be avoided?
- Or can we work on the naming to make it clearer?
- Could
PropsorOptionsbe used as constructor arguments, rather thanSettings. The latter seems more unfamiliar to me, but maybe used more extensively in deck.gl than I realize.
| * If dimensions>1, bin ID should be an array with [dimensions] elements; | ||
| * The data point will be skipped if bin ID is null. | ||
| */ | ||
| getBin: VertexAccessor<number | number[] | null, any>; |
There was a problem hiding this comment.
Nit: Always make it an array for cleaner types? Or there is a big enough convenience in allowing a single number?
| */ | ||
| getBin: VertexAccessor<number | number[] | null, any>; | ||
| /** Accessor to map each data point to a weight value, defined per channel */ | ||
| getWeight: VertexAccessor<number>[]; |
| export type CPUAggregationProps = AggregationProps & {}; | ||
|
|
||
| export type Bin = { | ||
| id: number | number[]; |
There was a problem hiding this comment.
Plural?
Suggested change
| id: number | number[]; | |
| ids: number | number[]; |
| attributes: {} | ||
| }; | ||
|
|
||
| protected getBinId: CPUAggregatorSettings['getBin']; |
There was a problem hiding this comment.
Nit: probably clearer to type out the callback types here, rather than referencing another type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #7457
Change List
CPUAggregator