GoogleMapsOverlay: fix initial layer position on raster basemaps #8892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbigg
force-pushed
the
zbigg/googlemapsoverlay-raster-fix
branch
from
c8144e0
to
feffbe1
Compare
zbigg
changed the title
Pessimistress
approved these changes
May 13, 2024
donmccurdy
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8891
Background
Seems like with raster basemaps, initial render happens when canvas is not yet attached to any parent.
This patch ensures that we use declared canvas parent, even before canvas is attached to DOM.
Change List