Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(webgl): Fix spectorjs #2082

Merged
merged 2 commits into from
Apr 29, 2024
Merged

fix(webgl): Fix spectorjs #2082

merged 2 commits into from
Apr 29, 2024

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Apr 26, 2024 •
edited

Fixes #2080

Background

  • spector doesn't initialize right

Change List

  • change CDN, seems the babylon CDN is inactive/flaky (though this didn't seem to be the root cause)
  • Add types for SpectorJS
  • Change to initialize spector JS on context, not canvas
  • Streamline spectorjs props handling

@ibgreen ibgreen force-pushed the ib/fix-spectorjs branch 4 times, most recently from 2166ec5 to cf32213 Compare April 29, 2024 11:49
@ibgreen ibgreen merged commit f1d0645 into master Apr 29, 2024
2 checks passed
@ibgreen ibgreen deleted the ib/fix-spectorjs branch April 29, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spector.js errors with error glState.push is not a function
1 participant
@ibgreen