Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Using common Component to structure Settings page #736

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Spokeek
Copy link
Contributor

@Spokeek Spokeek commented Apr 6, 2024

As i was working on the settings page, i saw we had common components in the layout file.

I followed that use and placed a Section Component that wraps our entries in Cards for our various pages.

For now as a proposal i did the settings page and the logs as they were the more useful for.

This is only a proposal on how we can do our sections so we can keep the design homogeneous.

Tell me what you think about it.

image

@anatawa12
Copy link
Member

I think creating common components is excellent. Thank you for proposal.

I think sections should be in vertical, and path input and button should be grouped in another horizontal component.

@Spokeek
Copy link
Contributor Author

Spokeek commented Apr 7, 2024

I think sections should be in vertical, and path input and button should be grouped in another horizontal component.

I'll try to make this. Would it be so we have a seperate component for each horizontal group ? Like for the example of the two backup sections ?

@anatawa12
Copy link
Member

I think having common component for path and pick pair and put inside VSection component is good.

@Spokeek
Copy link
Contributor Author

Spokeek commented Apr 19, 2024

I Reworked it again, making use of the material Typography component.

Trying to follow the Component based structure.
May try to generalize the UI Components as well like the Table.

image
image
image

@Spokeek
Copy link
Contributor Author

Spokeek commented Apr 21, 2024

As i used my components for the log page, i also added a color hint to clearer the log level of each line.
image

@Spokeek
Copy link
Contributor Author

Spokeek commented Apr 21, 2024

And applied the table component to repository list
image

@anatawa12
Copy link
Member

When will this pr become ready to merge? I want to merge this and implement color theme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants