New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Using common Component to structure Settings page #736
base: master
Are you sure you want to change the base?
Conversation
I think creating common components is excellent. Thank you for proposal. I think sections should be in vertical, and path input and button should be grouped in another horizontal component. |
I'll try to make this. Would it be so we have a seperate component for each horizontal group ? Like for the example of the two backup sections ? |
I think having common component for path and pick pair and put inside VSection component is good. |
c96adad
to
54a84c8
Compare
49b8946
to
08bb665
Compare
When will this pr become ready to merge? I want to merge this and implement color theme |
As i was working on the settings page, i saw we had common components in the layout file.
I followed that use and placed a Section Component that wraps our entries in Cards for our various pages.
For now as a proposal i did the settings page and the logs as they were the more useful for.
This is only a proposal on how we can do our sections so we can keep the design homogeneous.
Tell me what you think about it.