-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(artifacts): add save() method on ArtifactCollection to allow persisting changes #7528
feat(artifacts): add save() method on ArtifactCollection to allow persisting changes #7528
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7528 +/- ##
==========================================
+ Coverage 74.27% 75.84% +1.56%
==========================================
Files 500 500
Lines 55658 54121 -1537
==========================================
- Hits 41342 41046 -296
+ Misses 13907 12668 -1239
+ Partials 409 407 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
ArtifactCollection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment, otherwise LGTM!
Description
This PR pulls the
description
andtags
fields, and allows changes to be made and saved directly via thesave
functionTesting
Tested locally to make sure description and tags were pulled correctly, added integration tests for saving