Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(sdk): DNM - more cleanups of new py client #7534

Draft
wants to merge 36 commits into
base: main
Choose a base branch
from
Draft

Conversation

raubitsj
Copy link
Member

@raubitsj raubitsj commented May 1, 2024

Description

  • Fixes WB-NNNNN
  • Fixes #NNNN

What does the PR do? Include a concise description of the PR contents.

  • I updated CHANGELOG.md, or it's not applicable

Testing

How was this PR tested?

Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 168 lines in your changes missing coverage. Please review.

Project coverage is 69.53%. Comparing base (1bcf50b) to head (fb95b03).
Report is 153 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7534      +/-   ##
==========================================
- Coverage   74.98%   69.53%   -5.46%     
==========================================
  Files         523      524       +1     
  Lines       54864    54992     +128     
==========================================
- Hits        41139    38236    -2903     
- Misses      13319    16505    +3186     
+ Partials      406      251     -155     
Flag Coverage Δ
func 40.27% <ø> (-3.08%) ⬇️
system 63.04% <ø> (+0.12%) ⬆️
unit 53.14% <0.00%> (-2.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/pkg/gowandb/session.go 0.00% <0.00%> (ø)
core/lang/core/runkeeper.go 0.00% <0.00%> (ø)
core/lang/core/wandbcore.go 0.00% <0.00%> (ø)
core/cmd/wandb-core/main.go 0.00% <0.00%> (-67.93%) ⬇️
core/pkg/gowandb/opts/sessionopts/sessionopts.go 0.00% <0.00%> (ø)
core/internal/launcher/launcher.go 0.00% <0.00%> (ø)
core/internal/processlib/processlib_linux.go 0.00% <0.00%> (ø)
core/pkg/gowandb/run.go 0.00% <0.00%> (ø)
core/pkg/server/server.go 0.00% <0.00%> (-60.87%) ⬇️
core/lang/core/interface_pb.go 0.00% <0.00%> (ø)
... and 1 more

... and 85 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants