Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(launch): only mark job as partial in artifact version metadata #7652

Conversation

bcsherma
Copy link
Contributor

Description

  • Fixes WB-NNNNN
  • Fixes #NNNN

What does the PR do? Include a concise description of the PR contents.

  • I updated CHANGELOG.md, or it's not applicable

Testing

How was this PR tested?

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.22%. Comparing base (b082e18) to head (be6380d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7652      +/-   ##
==========================================
+ Coverage   74.20%   75.22%   +1.01%     
==========================================
  Files         500      500              
  Lines       55747    54135    -1612     
==========================================
- Hits        41368    40722     -646     
+ Misses      13963    12996     -967     
- Partials      416      417       +1     
Flag Coverage Δ
func 41.37% <60.00%> (+0.05%) ⬆️
system 62.84% <100.00%> (-0.67%) ⬇️
unit 56.19% <80.00%> (+0.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
wandb/sdk/internal/job_builder.py 91.29% <100.00%> (+0.02%) ⬆️
wandb/sdk/launch/create_job.py 80.00% <100.00%> (+4.76%) ⬆️

... and 109 files with indirect coverage changes

@bcsherma bcsherma force-pushed the 05-15-fix_launch_overwrite_partial_job_metadata branch from 1cd559c to f42e9fa Compare May 15, 2024 23:50
@bcsherma bcsherma force-pushed the 05-15-fix_launch_only_mark_job_as_partial_in_artifact_version_metadata branch from 9cf7abc to b699b84 Compare May 15, 2024 23:50
@bcsherma bcsherma force-pushed the 05-15-fix_launch_overwrite_partial_job_metadata branch from f42e9fa to 4e34d5d Compare May 16, 2024 17:35
@bcsherma bcsherma force-pushed the 05-15-fix_launch_only_mark_job_as_partial_in_artifact_version_metadata branch from b699b84 to f4f4c3d Compare May 16, 2024 17:35
@bcsherma bcsherma force-pushed the 05-15-fix_launch_overwrite_partial_job_metadata branch from 4e34d5d to ffff3c5 Compare May 16, 2024 18:02
@bcsherma bcsherma force-pushed the 05-15-fix_launch_only_mark_job_as_partial_in_artifact_version_metadata branch from f4f4c3d to efcf498 Compare May 16, 2024 18:03
@bcsherma bcsherma force-pushed the 05-15-fix_launch_overwrite_partial_job_metadata branch from ffff3c5 to 7ec97ff Compare May 16, 2024 19:55
@bcsherma bcsherma force-pushed the 05-15-fix_launch_only_mark_job_as_partial_in_artifact_version_metadata branch from efcf498 to 8ef6b0c Compare May 16, 2024 19:55
@bcsherma bcsherma force-pushed the 05-15-fix_launch_overwrite_partial_job_metadata branch from 7ec97ff to e10eea2 Compare May 16, 2024 20:22
@bcsherma bcsherma force-pushed the 05-15-fix_launch_only_mark_job_as_partial_in_artifact_version_metadata branch from 8ef6b0c to 1e46189 Compare May 16, 2024 20:22
@bcsherma bcsherma force-pushed the 05-15-fix_launch_overwrite_partial_job_metadata branch from e10eea2 to a4de8a8 Compare May 17, 2024 17:38
@bcsherma bcsherma force-pushed the 05-15-fix_launch_only_mark_job_as_partial_in_artifact_version_metadata branch from 1e46189 to ef98c63 Compare May 17, 2024 17:39
@bcsherma bcsherma force-pushed the 05-15-fix_launch_overwrite_partial_job_metadata branch from a4de8a8 to b25062f Compare May 17, 2024 18:21
@bcsherma bcsherma force-pushed the 05-15-fix_launch_only_mark_job_as_partial_in_artifact_version_metadata branch 2 times, most recently from caaa10d to d7bfe2d Compare May 17, 2024 18:26
@bcsherma bcsherma force-pushed the 05-15-fix_launch_overwrite_partial_job_metadata branch from b25062f to 0fd89eb Compare May 17, 2024 18:28
@bcsherma bcsherma force-pushed the 05-15-fix_launch_only_mark_job_as_partial_in_artifact_version_metadata branch from d7bfe2d to 1f3abd4 Compare May 17, 2024 18:28
@bcsherma bcsherma force-pushed the 05-15-fix_launch_overwrite_partial_job_metadata branch from 0fd89eb to 56fca2a Compare May 17, 2024 18:37
@bcsherma bcsherma force-pushed the 05-15-fix_launch_only_mark_job_as_partial_in_artifact_version_metadata branch from 1f3abd4 to 424ef34 Compare May 17, 2024 18:37
@bcsherma bcsherma force-pushed the 05-15-fix_launch_overwrite_partial_job_metadata branch from 56fca2a to 0a93a41 Compare May 17, 2024 18:41
@bcsherma bcsherma force-pushed the 05-15-fix_launch_only_mark_job_as_partial_in_artifact_version_metadata branch from 424ef34 to 48e25f7 Compare May 17, 2024 18:41
@bcsherma bcsherma force-pushed the 05-15-fix_launch_overwrite_partial_job_metadata branch from 0a93a41 to 94303a4 Compare May 17, 2024 20:49
@bcsherma bcsherma force-pushed the 05-15-fix_launch_only_mark_job_as_partial_in_artifact_version_metadata branch from 48e25f7 to cb433e6 Compare May 17, 2024 20:49
@bcsherma bcsherma force-pushed the 05-15-fix_launch_overwrite_partial_job_metadata branch from 94303a4 to 4cb8cfb Compare May 17, 2024 21:13
@bcsherma bcsherma force-pushed the 05-15-fix_launch_only_mark_job_as_partial_in_artifact_version_metadata branch from cb433e6 to e82e65b Compare May 17, 2024 21:13
@bcsherma bcsherma force-pushed the 05-15-fix_launch_overwrite_partial_job_metadata branch from 4cb8cfb to 922f28a Compare May 17, 2024 21:21
@bcsherma bcsherma force-pushed the 05-15-fix_launch_overwrite_partial_job_metadata branch from 2e5f554 to 1ba01d9 Compare May 21, 2024 20:13
@bcsherma bcsherma force-pushed the 05-15-fix_launch_only_mark_job_as_partial_in_artifact_version_metadata branch from ecde78e to dda1ead Compare May 21, 2024 20:13
@bcsherma bcsherma force-pushed the 05-15-fix_launch_overwrite_partial_job_metadata branch from 1ba01d9 to 6df8fc6 Compare May 21, 2024 20:19
@bcsherma bcsherma force-pushed the 05-15-fix_launch_only_mark_job_as_partial_in_artifact_version_metadata branch from dda1ead to 3374c48 Compare May 21, 2024 20:20
@bcsherma bcsherma force-pushed the 05-15-fix_launch_overwrite_partial_job_metadata branch from 6df8fc6 to 30e0cbb Compare May 21, 2024 21:26
@bcsherma bcsherma force-pushed the 05-15-fix_launch_only_mark_job_as_partial_in_artifact_version_metadata branch from 3374c48 to b8be138 Compare May 21, 2024 21:28
@bcsherma bcsherma force-pushed the 05-15-fix_launch_overwrite_partial_job_metadata branch from 30e0cbb to e333d42 Compare May 22, 2024 16:43
@bcsherma bcsherma force-pushed the 05-15-fix_launch_only_mark_job_as_partial_in_artifact_version_metadata branch from b8be138 to e31f293 Compare May 22, 2024 16:43
@bcsherma bcsherma force-pushed the 05-15-fix_launch_overwrite_partial_job_metadata branch from e333d42 to b77b2ce Compare May 22, 2024 21:27
@bcsherma bcsherma force-pushed the 05-15-fix_launch_only_mark_job_as_partial_in_artifact_version_metadata branch from e31f293 to 3b084f3 Compare May 22, 2024 21:27
@bcsherma bcsherma force-pushed the 05-15-fix_launch_overwrite_partial_job_metadata branch from b77b2ce to 45b6b1d Compare May 23, 2024 16:18
@bcsherma bcsherma force-pushed the 05-15-fix_launch_only_mark_job_as_partial_in_artifact_version_metadata branch from 3b084f3 to 32763c6 Compare May 23, 2024 16:18
@bcsherma bcsherma force-pushed the 05-15-fix_launch_overwrite_partial_job_metadata branch from 5226ad0 to cfb33a6 Compare May 24, 2024 16:27
@bcsherma bcsherma force-pushed the 05-15-fix_launch_only_mark_job_as_partial_in_artifact_version_metadata branch from 32763c6 to 153d875 Compare May 24, 2024 16:28
@bcsherma bcsherma force-pushed the 05-15-fix_launch_overwrite_partial_job_metadata branch from cfb33a6 to 9cd99e1 Compare May 24, 2024 16:29
@bcsherma bcsherma force-pushed the 05-15-fix_launch_only_mark_job_as_partial_in_artifact_version_metadata branch from 153d875 to d3f56b6 Compare May 24, 2024 16:29
@bcsherma bcsherma force-pushed the 05-15-fix_launch_overwrite_partial_job_metadata branch 2 times, most recently from d99e51a to 0f5ac92 Compare May 29, 2024 17:46
Base automatically changed from 05-15-fix_launch_overwrite_partial_job_metadata to main May 29, 2024 18:18
@bcsherma bcsherma force-pushed the 05-15-fix_launch_only_mark_job_as_partial_in_artifact_version_metadata branch from d3f56b6 to e86e210 Compare May 29, 2024 18:20
@bcsherma bcsherma marked this pull request as ready for review May 29, 2024 18:21
@bcsherma bcsherma force-pushed the 05-15-fix_launch_only_mark_job_as_partial_in_artifact_version_metadata branch 3 times, most recently from 022d69c to d9ad596 Compare May 29, 2024 20:30
@bcsherma bcsherma force-pushed the 05-15-fix_launch_only_mark_job_as_partial_in_artifact_version_metadata branch from d9ad596 to be6380d Compare May 29, 2024 20:57
@bcsherma bcsherma merged commit 89167f8 into main May 29, 2024
41 checks passed
@bcsherma bcsherma deleted the 05-15-fix_launch_only_mark_job_as_partial_in_artifact_version_metadata branch May 29, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants