feat(sdk): enable uploading ranges of files in core #7660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7660 +/- ##
==========================================
+ Coverage 74.26% 75.85% +1.58%
==========================================
Files 500 500
Lines 55656 54061 -1595
==========================================
- Hits 41334 41007 -327
+ Misses 13915 12646 -1269
- Partials 407 408 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
moredatarequired
force-pushed
the
allow-offset-uploads
branch
from
db1195f
to
3525de7
Compare
kptkin
reviewed
May 21, 2024
kptkin
reviewed
May 21, 2024
Comment on lines
+73
to
+81
| if task.Offset > 0 || (task.Length > 0 && task.Length < stat.Size()) { | ||
| if task.Offset+task.Length > stat.Size() { | ||
| ft.logger.Error("file transfer: upload: offset + length is greater than the file size", | ||
| "offset", task.Offset, "length", task.Length, "file size", stat.Size()) | ||
| task.Length = int64(stat.Size() - task.Offset) | ||
| } | ||
| sectionReader := io.NewSectionReader(file, task.Offset, task.Length) | ||
| reader = sectionReader | ||
| task.Size = task.Length |
There was a problem hiding this comment.
i think in any case this requires explanation it's not clear why you do the math you do
why it doesn't include the range
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
OffsetandLengthfields to thefiletransfer.Tasktype, and alterDefaultFileTransfer.Uploadso that if those are non-zero only the specified range is uploaded.This will be used for multipart uploads (draft: #7659).
Question: the
Tasktakes a file path, rather than a file handle. This means that to upload ranges, it needs to open the file (create a file handle) for each range it needs to upload, and large files (>1TB) can be broken up into up to 10,000 pieces. Is this a problem?Testing
Added two small unit tests for functionality.