Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(launch): Support Azure repo URI format in Launch #7664

Merged
merged 3 commits into from
May 20, 2024

Conversation

KyleGoyette
Copy link
Contributor

@KyleGoyette KyleGoyette commented May 17, 2024

Description

  • Fixes WB-NNNNN
  • Fixes #NNNN

What does the PR do? Include a concise description of the PR contents.

  • I updated CHANGELOG.md, or it's not applicable

Testing

How was this PR tested?

@KyleGoyette KyleGoyette changed the title fix(launch): Support Azure Repo ssh format as git uri fix(launch): Support Azure repo URI format in Launch May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.83%. Comparing base (07f19a6) to head (9e8c06c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7664      +/-   ##
==========================================
+ Coverage   74.28%   75.83%   +1.54%     
==========================================
  Files         500      500              
  Lines       55658    54052    -1606     
==========================================
- Hits        41345    40988     -357     
+ Misses      13907    12657    -1250     
- Partials      406      407       +1     
Flag Coverage Δ
func 41.37% <100.00%> (+<0.01%) ⬆️
system 63.46% <100.00%> (-0.03%) ⬇️
unit 56.39% <100.00%> (+1.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
wandb/sdk/launch/utils.py 74.80% <100.00%> (ø)

... and 104 files with indirect coverage changes

@KyleGoyette KyleGoyette force-pushed the launch/fix-azure-ssh-git-uri-support branch from c1de546 to 9e8c06c Compare May 17, 2024 22:25
@KyleGoyette KyleGoyette marked this pull request as ready for review May 18, 2024 17:55
@KyleGoyette KyleGoyette requested a review from a team as a code owner May 18, 2024 17:55
@KyleGoyette KyleGoyette merged commit 0383350 into main May 20, 2024
43 checks passed
@KyleGoyette KyleGoyette deleted the launch/fix-azure-ssh-git-uri-support branch May 20, 2024 17:55
@KyleGoyette KyleGoyette restored the launch/fix-azure-ssh-git-uri-support branch May 20, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants