Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): Reports API: Fix backend name mapping for ScatterPlots #7667

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andrewtruong
Copy link
Contributor

@andrewtruong andrewtruong commented May 19, 2024

Description

This PR:

  1. Fixes ScatterPlot to use the Parallel Coordinates Plot style of backend metric naming
  2. Updates ParallelCoordinatesMetric to SummaryOrConfigOnlyMetric to be more explicit about supported metric types
  • I updated CHANGELOG.md, or it's not applicable

Testing

How was this PR tested?

Copy link

codecov bot commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.81%. Comparing base (07f19a6) to head (bbaca47).
Report is 59 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7667      +/-   ##
==========================================
+ Coverage   74.28%   75.81%   +1.53%     
==========================================
  Files         500      500              
  Lines       55658    54054    -1604     
==========================================
- Hits        41345    40983     -362     
+ Misses      13907    12664    -1243     
- Partials      406      407       +1     
Flag Coverage Δ
func 41.39% <0.00%> (+0.02%) ⬆️
system 63.43% <100.00%> (-0.05%) ⬇️
unit 56.40% <100.00%> (+1.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
wandb/apis/reports/v2/interface.py 87.63% <100.00%> (+0.83%) ⬆️

... and 107 files with indirect coverage changes

@andrewtruong andrewtruong changed the title fix(reports): Fix backend name mapping for ScatterPlots fix(sdk): Reports API: Fix backend name mapping for ScatterPlots May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant