Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat:Add feedback button (#106) #116

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

littlestar642
Copy link
Collaborator

@littlestar642 littlestar642 commented Feb 24, 2018

Fixes #106
Deployment available at
https://salty-peak-60673.herokuapp.com/

}

#feedBtn{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no camelcasing


cancel.addEventListener('click', () => {
let confirm = document.querySelector('#confirm');
confirm.classList.remove('visible');
});

cancelFeed.addEventListener('click', () => {
let confirmFeedback = document.querySelector('#feedback')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why two diff vars to select #feedback?

@littlestar642 littlestar642 changed the title Feat:Add feedback button Feat:Add feedback button Feb 25, 2018
@littlestar642 littlestar642 changed the title Feat:Add feedback button Feat:Add feedback button (#106) Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants