Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move packages to one/root location, fix dev script for windows #1

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

mubaidr
Copy link

@mubaidr mubaidr commented Apr 23, 2018

Initial intent was to to just fix the dev/build script because cp command is not available in Windows but I noticed packages an be moved to one location too.

@fritx
Copy link
Member

fritx commented Apr 24, 2018

@mubaidr cool, really needs Windows contribution!
.. but I still want to keep the "Two package.json structure".
https://www.electron.build/tutorials/two-package-structure

Also, I guess the changes would break packaging via npm run build.

@mubaidr
Copy link
Author

mubaidr commented Apr 24, 2018

Yes, I see Windows build scripts are also missing, will work on that too.

Since version 8 electron-builder rebuilds only production dependencies, so, you are not forced to use two package.json structure.

Or am I missing something?

@fritx
Copy link
Member

fritx commented Apr 25, 2018

@mubaidr yeah looks right, but when I try your fork from scratch, packaged app would throw error:

@fritx
Copy link
Member

fritx commented Apr 25, 2018

I'm not sure but if we deprecate the two-package-structure, how should we tell electron-builder to copy node_modules in dependencies to the packaged app?

@mubaidr
Copy link
Author

mubaidr commented Apr 25, 2018

We are now making the root package.json to be the electron app package json, so everything should work as earlier.

Honestly, I have not yet tried build script, still working on dev script, parcel does not seem to support electron.js environment. see this:
parcel-bundler/parcel#1244

Once the dev is finalized, I will work on build script.

If you have any info regarding this, please share.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants