Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/update code format, replace declaration with expressions #846

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

potapovDim
Copy link
Contributor

@potapovDim potapovDim commented Sep 18, 2023

Updated code format second iteration

@udarrr
Copy link
Member

udarrr commented Sep 19, 2023

Hi @potapovDim I am just curious about why did you do that ? What's wrong with function declaration?

@potapovDim
Copy link
Contributor Author

@udarrr nothing wrong with fn declaration, just to have a common code approach format across library i started to update it to expression format also expression could not be hosted in a way as declarations so better for reading, would be also good to add jsdoc comments and some lint format/prettier

@christian-bromann
Copy link
Member

@potapovDim maybe it makes sense to introduce Prettier or EsLint to ensure that the next contributor doesn't switch this around again. I don't mind which code style we go with as long as we ensure we stick with it using these tools.

@potapovDim
Copy link
Contributor Author

potapovDim commented Sep 20, 2023

@christian-bromann i can do that, can we merge this one and i will proceed with that next steps ? or do you want me to add this one as a part current PR ? i would also want to have pre - commit hook with lint and unit tests if it sounds suitable ?

@christian-bromann
Copy link
Member

or do you want me to add this one as a part current PR ?

Let's add it to this PR if you don't mind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants