-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select proper input via ancestor label when multiple match #12884
Select proper input via ancestor label when multiple match #12884
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing stuff, LGTM 👍
8f2450d
to
89421eb
Compare
My apologies @christian-bromann, I left in a lingering I removed the If you want it, backported PR available at #12889. |
haha, no worries, happens to me all the time 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Hey evankennedy 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
Proposed changes
Fixes #12883
Types of changes
Checklist
Backport Request
v9
and doesn't need to be back-portedFurther comments
Reviewers: @webdriverio/project-committers @christian-bromann @erwinheitzman