Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select proper input via ancestor label when multiple match #12884

Conversation

evankennedy
Copy link
Contributor

@evankennedy evankennedy commented May 17, 2024

Proposed changes

Fixes #12883

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

Further comments

Reviewers: @webdriverio/project-committers @christian-bromann @erwinheitzman

Copy link

linux-foundation-easycla bot commented May 17, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: evankennedy / name: Evan Kennedy (89421eb)

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label May 17, 2024
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing stuff, LGTM 👍

@evankennedy
Copy link
Contributor Author

My apologies @christian-bromann, I left in a lingering .only. That's what I get for late-night coding on a new project.

I removed the .only and squashed all the commits together. Tests should pass now. Thanks for hanging in there with me.

If you want it, backported PR available at #12889.

@christian-bromann
Copy link
Member

That's what I get for late-night coding on a new project.

haha, no worries, happens to me all the time 😉

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann merged commit 79b2f01 into webdriverio:main May 18, 2024
44 checks passed
@wdio-bot
Copy link
Contributor

Hey evankennedy 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

@evankennedy evankennedy deleted the multiple-aria-input-by-label-fix branch May 20, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Expensable $50 💸 PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
3 participants