Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating version reference for node-dir in package.json to use github… #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JohnKeatley
Copy link

@JohnKeatley JohnKeatley commented Oct 10, 2018

… instead of npm.

This should bring in the updated code to fix the empty folder error.

wayou/node-dir@a5cdb0e

This should solve the issue reported here which was caused by node-dir returning an "undefined" when meeting an empty folder. This wasn't fixed as of 0.1.17 but has been fixed with the latest commit to node-dir's master branch.

@sebinsua
Copy link

sebinsua commented Feb 4, 2020

Another option seems to be to swap to node-require-context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants