Fix issuer index in context of idp update/replace #3748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisx
force-pushed
the
fisx-spar-refactorings-2023-11-27
branch
from
119b241
to
20a4ab4
Compare
zebot
added
the
ok-to-test
fisx
changed the title
fisx
force-pushed
the
fisx-spar-refactorings-2023-11-27
branch
from
e083a2e
to
39fd043
Compare
fisx
force-pushed
the
fisx-spar-refactorings-2023-11-27
branch
3 times, most recently
from
6133171
to
c2788d0
Compare
fisx
changed the title
fisx
force-pushed
the
fisx-spar-refactorings-2023-11-27
branch
from
14081b5
to
0d17e81
Compare
This is a bug that has caused some garbage not being collected in C*. Non-critical.
This means it's allowed to revert idp updates without "idp-already-used" error.
The old logic was incoherent and incomprehensible.
- remove threadDelay (temporarily added for ruling out race conditions during debugging). - make sure users are removed right after it should happen, not at the end of the test.
fisx
force-pushed
the
fisx-spar-refactorings-2023-11-27
branch
from
0d17e81
to
d982ffa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-5692
Checklist
changelog.d