Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not spawn nginz on CI #3760

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Do not spawn nginz on CI #3760

wants to merge 2 commits into from

Conversation

pcapriotti
Copy link
Contributor

There is no need to spawn nginx when creating a dynamic backend, as ingresses are started separately and persist through the test run.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Dec 4, 2023
@pcapriotti pcapriotti force-pushed the pcapriotti/flakes/proper-cleanup branch 2 times, most recently from 5a779cf to faf0d77 Compare December 7, 2023 09:46
@pcapriotti pcapriotti force-pushed the pcapriotti/integration-ci-nginz branch from 02d3c87 to ee66779 Compare December 7, 2023 10:21
Base automatically changed from pcapriotti/flakes/proper-cleanup to develop December 8, 2023 09:24
@pcapriotti pcapriotti force-pushed the pcapriotti/integration-ci-nginz branch from ee66779 to 2c7521c Compare December 12, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pcapriotti @zebot