-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rusty-jwt-tools: build with crate2nix #3780
Draft
flokli
wants to merge
4
commits into
develop
Choose a base branch
from
rusty-jwt-tools-crate2nix
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niv wants us to update that file.
We didn't bump nixpkgs recently, and need some fixes from crate2nix to package more of our rust packages with it. Pull in crate2nix upstream (but give it our nixpkgs).
zebot
added
the
ok-to-test
Approved for running tests in CI, overrides not-ok-to-test if both labels exist
label
Dec 14, 2023
flokli
changed the title
Rusty jwt tools crate2nix
rusty-jwt-tools: build with crate2nix
Dec 14, 2023
We don't need to pass this ancient nixpkgs pin into the rusty-jwt-tools nix rust build.
flokli
force-pushed
the
rusty-jwt-tools-crate2nix
branch
from
December 14, 2023 10:11
bba02d5
to
e895142
Compare
MangoIV
reviewed
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog.d entry is missing afaict.
MangoIV
approved these changes
Dec 14, 2023
CI is mad though, seems like something doesn't evaluate... |
It's not gonna work, this needs to stay a draft until the crate2nix issue is resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses crate2nix to build rusty-jwt-tools.
Checklist
changelog.d