Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rusty-jwt-tools: build with crate2nix #3780

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Dec 14, 2023

This uses crate2nix to build rusty-jwt-tools.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

niv wants us to update that file.
We didn't bump nixpkgs recently, and need some fixes from crate2nix to
package more of our rust packages with it.

Pull in crate2nix upstream (but give it our nixpkgs).
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Dec 14, 2023
@flokli flokli changed the title Rusty jwt tools crate2nix rusty-jwt-tools: build with crate2nix Dec 14, 2023
We don't need to pass this ancient nixpkgs pin into the rusty-jwt-tools
nix rust build.
Copy link
Contributor

@MangoIV MangoIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog.d entry is missing afaict.

nix/pkgs/rusty_jwt_tools_ffi/README.md Show resolved Hide resolved
@MangoIV MangoIV self-requested a review December 14, 2023 13:49
@MangoIV
Copy link
Contributor

MangoIV commented Dec 14, 2023

CI is mad though, seems like something doesn't evaluate...

@flokli
Copy link
Contributor Author

flokli commented Dec 14, 2023

CI is mad though, seems like something doesn't evaluate...

It's not gonna work, this needs to stay a draft until the crate2nix issue is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants