Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to multi-SFT options other than the TURN multiplexed one per WPB-2566 #3860

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

arthurwolf
Copy link
Contributor

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jan 31, 2024
Copy link
Contributor

@rohan-wire rohan-wire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a number of changes to reflect that multi-SFT is only supported in the configuration of the last diagram. I proposed a new diagram based on the first diagram in the original page.

  1. Please redraw multi-sft-concept.png in a consistent style.
  2. Please save the original first diagram (multi-sft-noturn.png), as Wire will want to support the direct SFT to SFT (sans Federation TURN server) model in the future for any customer other than Bund. This was actually implemented but removed as M2 shipped. I don't think there is any plan to support the TURN server to TURN server with DTLS muxing, but I thought we would get a review from Dusan and/or Chris before deleting img/multi-sft-turn.png
  3. Please remove all references to Restund in this page and its diagrams and replace them with "TURN server". Please do not reference coTURN in any of the understanding sections. We should only reference coTURN or Restund if absolutely referring to something like migrating from TURN server to the other.

@rohan-wire rohan-wire changed the title commenting out the docs as per the ticket Remove references to multi-SFT options other than the TURN multiplexed one per WPB-2566 Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants