Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WPB-6718] Implement TLS support in Wire's Redis interface #4016

Merged
merged 19 commits into from
May 27, 2024
Merged

[WPB-6718] Implement TLS support in Wire's Redis interface #4016

merged 19 commits into from
May 27, 2024

Conversation

mdimjasevic
Copy link
Contributor

@mdimjasevic mdimjasevic commented Apr 24, 2024 •
edited by akshaymankar

https://wearezeta.atlassian.net/browse/WPB-6718

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Apr 24, 2024
@akshaymankar akshaymankar force-pushed the redis-tls branch 3 times, most recently from fe236e7 to 234b818 Compare May 2, 2024 12:37
@akshaymankar akshaymankar marked this pull request as ready for review May 2, 2024 14:25
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

akshaymankar and others added 19 commits May 27, 2024 09:50
@akshaymankar
dockerephemeral: Run redis-cluster with TLS
75d996f
@akshaymankar
WIP
d6e5a9f
@mdimjasevic @akshaymankar
Debugging: Increase Gundeck's logging level to info
1ae20e2
@akshaymankar
Give every redis node its own cert
fca3a13
@akshaymankar
Update hedis pin to support TLS with all nodes of a redis-cluster
ed72789
@akshaymankar
gundeck.integration.yaml: Use IP address of the redis cluster node
a89769f 
The certificates are valid only for IP addresses
@akshaymankar
Use fork of crypton-x509-validation to support IP Address validation
74dc5e2
@pcapriotti @akshaymankar
charts/gundeck: Support TLS (without ability to set a custom CA)
7fd22f3 
hack: Enable TLS on redis and configure gundeck to not verify CA
@akshaymankar
charts/{gundeck,integration}: Verify redis TLS with custom CA
4451c67 
hack: Configure custom CA for redis in gundeck
@akshaymankar
gundeck-config: verifyTls -> insecureSkipVerifyTls
9d1157b 
Make it more obvious that messing witht this value is insecure
@akshaymankar
changelog
43e0602
@akshaymankar
docs
bcf51f2
@akshaymankar
Fix typo
de44305
@akshaymankar
This commit doesn't make a difference, but its nicer like this
64d95aa
@akshaymankar
Fix more typos
ebdc79a
@akshaymankar
revert unnecessary log level change
b5367fe
@akshaymankar
gundeck.integration.yaml: Don't skip TLS validation
787a3e3
@akshaymankar
Throw away throw away code
d543d1d
@akshaymankar
Gundeck.Env: Simplify code
854b02e
@akshaymankar akshaymankar merged commit 352fbda into develop May 27, 2024
8 checks passed
@akshaymankar akshaymankar deleted the redis-tls branch May 27, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaymankar akshaymankar akshaymankar approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mdimjasevic @akshaymankar @zebot @pcapriotti