Add more fingerprint verification tests for bots #4027
Conversation
zebot
added
the
ok-to-test
MangoIV
force-pushed
the
test-bot-fp-verification
branch
3 times, most recently
from
b2e31c2
to
0a38788
Compare
|
how many "hi ci"s can we score until it finally doesn't flake? |
stefanwire
force-pushed
the
test-bot-fp-verification
branch
from
0265668
to
d485b38
Compare
|
|
this PR is truly cursed. |
MangoIV
force-pushed
the
test-bot-fp-verification
branch
2 times, most recently
from
efd5c9f
to
07c20c1
Compare
|
I have a near 100% flake rate, what’s wrong with this PR? Is it possible that this test somehow influences others? There’s one think that takes particularly long, is it possible that this is why other tests fail? |
stefanwire
force-pushed
the
test-bot-fp-verification
branch
3 times, most recently
from
ff1618a
to
af03ba2
Compare
coming from galley
stefanwire
force-pushed
the
test-bot-fp-verification
branch
from
3d3ebde
to
42b279a
Compare
The fork contains a patch to verifyX509 which clears the openssl error stack after a verification failure.
integration/test/Testlib/Certs.hs
Outdated
|
|
||
| -- | the minimum key size is hard coded to be 256 bytes (= 2048 bits) | ||
| -- | ||
| -- TODO(mangoiv): key generation takes an (actually multiple) eternities |
There was a problem hiding this comment.
Has this TODO been resolved?
There was a problem hiding this comment.
Yes, by using constant p and q for RSA keys. Should be fine for tests.
There was a problem hiding this comment.
Let's delete the comment then :)
nix/haskell-pins.nix
Outdated
|
|
||
| HsOpenSSL = { | ||
| src = fetchgit { | ||
| url = "https://github.com/wireapp/HsOpenSSL"; | ||
| rev = "2d7afef71ecdc2edd579dde072b75674da1fb730"; | ||
| sha256 = "sha256-wLjDOMokKELVH30bYNyDAYT3ux3pdMq4sIeMZLQOSG8="; | ||
| }; | ||
| }; | ||
|
|
There was a problem hiding this comment.
There's been a new release of HsOpenSSL already with this! So, this could be moved to hackagePins.
| cryptostore = hlib.addBuildDepends (hlib.dontCheck (hlib.appendConfigureFlags hsuper.cryptostore [ "-fuse_crypton" ])) | ||
| [ hself.crypton hself.crypton-x509 hself.crypton-x509-validation ]; |
There was a problem hiding this comment.
The comment above this belongs to the line below this.
libs/ssl-util/src/Ssl/Util.hs
Outdated
| import Control.Exception hiding (catch) | ||
| import Data.ByteString.Builder | ||
| import Data.Byteable (constEqBytes) | ||
| import Data.Dynamic (fromDynamic) | ||
| import Data.Time.Clock (getCurrentTime) | ||
| import Imports | ||
| import Network.HTTP.Client.Internal | ||
| import OpenSSL.BN (integerToMPI) | ||
| import OpenSSL.EVP.Digest (Digest, digestLBS) | ||
| import OpenSSL.EVP.PKey (SomePublicKey, toPublicKey) | ||
| import OpenSSL.EVP.Digest (digestLBS) | ||
| import OpenSSL.EVP.Internal | ||
| import OpenSSL.EVP.PKey |
There was a problem hiding this comment.
I think this should be reverted given there was no actual code change in this file, looks like we depend on some Internal module for no reason.
integration/test/Test/LegalHold.hs
Outdated
| -- We used to throw LegalholdConflictsOldClients if clients didn't have LH capability, but we | ||
| -- don't do that any more because that broke things. | ||
| -- Related: https://github.com/wireapp/wire-server/pull/4056 |
There was a problem hiding this comment.
Weird place to put a comment, can we leave it as it was please?
https://wearezeta.atlassian.net/browse/WPB-6350
Checklist
changelog.d