Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPB-7161] Generalise catchErrors middleware #4038

Merged
merged 2 commits into from
May 22, 2024

Conversation

battermann
Copy link
Contributor

@battermann battermann commented May 3, 2024

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label May 3, 2024
@mdimjasevic
Copy link
Contributor

Is this done for https://wearezeta.atlassian.net/browse/WPB-7161?

@pcapriotti
Copy link
Contributor

Is this done for https://wearezeta.atlassian.net/browse/WPB-7161?

I think so.

@mdimjasevic
Copy link
Contributor

Great! I'm introducing request IDs in all the services and then I'll leave the federator to you as part of this PR.

@mdimjasevic mdimjasevic changed the title Generalise catchErrors middleware [WPB-7161] Generalise catchErrors middleware May 21, 2024
@mdimjasevic
Copy link
Contributor

I tagged the PR with a ticket number in the title so it gets tracked automatically by Jira. Let me know if this is a wrong ticket!

@battermann battermann merged commit 4a09672 into q1-2024 May 22, 2024
8 checks passed
@battermann battermann deleted the battermann/fix-federation-request-id branch May 22, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants