-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WPB-9065] Stop supporting phone numbers in supported client API versions #4045
Draft
mdimjasevic
wants to merge
12
commits into
develop
Choose a base branch
from
wpb-9065/stop-support-phone-numbers-v0-v5
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
Approved for running tests in CI, overrides not-ok-to-test if both labels exist
label
May 9, 2024
mdimjasevic
force-pushed
the
wpb-9065/stop-support-phone-numbers-v0-v5
branch
3 times, most recently
from
May 13, 2024 14:18
22091b4
to
c8abf1b
Compare
mdimjasevic
force-pushed
the
wpb-9065/stop-support-phone-numbers-v0-v5
branch
5 times, most recently
from
May 14, 2024 09:51
1108b6d
to
738e708
Compare
mdimjasevic
force-pushed
the
wpb-9065/stop-support-phone-numbers-v0-v5
branch
from
May 14, 2024 11:16
b44dc62
to
b2b05dd
Compare
mdimjasevic
force-pushed
the
wpb-9065/stop-support-phone-numbers-v0-v5
branch
from
May 15, 2024 11:12
f8ce0ec
to
43fb173
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some golden tests have changed because support for phone-based account registration and activation has been disabled. However, there are new golden tests that fail to parse if a phone number or phone activation code was provided in an endpoint.
Tracked by https://wearezeta.atlassian.net/browse/WPB-9065.
Integration tests still failing in Brig:
Checklist
changelog.d
docs/src/developer/reference/user/activation.md
should be modifiedWire.API.User.User
) that have a phone number in their identity (userIdentity
) to JSON