Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPB-9065] Stop supporting phone numbers in supported client API versions #4045

Draft
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

mdimjasevic
Copy link
Contributor

@mdimjasevic mdimjasevic commented May 9, 2024

Some golden tests have changed because support for phone-based account registration and activation has been disabled. However, there are new golden tests that fail to parse if a phone number or phone activation code was provided in an endpoint.

Tracked by https://wearezeta.atlassian.net/browse/WPB-9065.

Integration tests still failing in Brig:

  • auth/login/phone
  • put i/users/:uid/sso-id
  • post /activate/send - 403 prefix excluded
  • post /activate/send - 200
  • put /self/password - 400
  • head /self/password - 200/404
  • put /self/phone - 409
  • put /self/phone - 403
  • put /self/phone - 202
  • post /register - 201 existing activation
  • post /register - 201 + no email
  • testCreateUserWithInvalidVerificationCode - post /register - 400 (with preverified)
  • post /register - 201 (with preverified)

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines
  • See if the "Phone/email whitelist" section of docs/src/developer/reference/user/activation.md should be modified
  • Have golden tests for serializing users (Wire.API.User.User) that have a phone number in their identity (userIdentity) to JSON
  • Check if there's an integration test for getting an activation code via email

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label May 9, 2024
@mdimjasevic mdimjasevic force-pushed the wpb-9065/stop-support-phone-numbers-v0-v5 branch 3 times, most recently from 22091b4 to c8abf1b Compare May 13, 2024 14:18
@mdimjasevic mdimjasevic force-pushed the wpb-9065/stop-support-phone-numbers-v0-v5 branch 5 times, most recently from 1108b6d to 738e708 Compare May 14, 2024 09:51
@mdimjasevic mdimjasevic force-pushed the wpb-9065/stop-support-phone-numbers-v0-v5 branch from b44dc62 to b2b05dd Compare May 14, 2024 11:16
@mdimjasevic mdimjasevic force-pushed the wpb-9065/stop-support-phone-numbers-v0-v5 branch from f8ce0ec to 43fb173 Compare May 15, 2024 11:12
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants