Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace uuidjs with uuid WPB-7240 #6221

Merged
merged 1 commit into from
May 21, 2024

Conversation

svitovyda
Copy link
Contributor

@svitovyda svitovyda commented May 17, 2024

Motivation: bump uuidjs from v 4.2.13 to v 5.1.0 causes problems with jest that are hard to resolve.
And since uuid has 103,276,467 weekly downloads vs uuidjs - 9,841, it makes sense to use uuid.

Pull Request Checklist

  • My code is covered by tests

@svitovyda svitovyda requested a review from a team May 17, 2024 18:56
@svitovyda svitovyda force-pushed the fix/replace-uuidjs-with-uuid-WPB-7050 branch from 4aa4fd0 to e928dbd Compare May 20, 2024 12:47
Copy link
Contributor

@tlebon tlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine

@svitovyda svitovyda force-pushed the fix/replace-uuidjs-with-uuid-WPB-7050 branch from e928dbd to 8c413b6 Compare May 21, 2024 22:23
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@svitovyda svitovyda merged commit d51550d into main May 21, 2024
8 checks passed
@svitovyda svitovyda deleted the fix/replace-uuidjs-with-uuid-WPB-7050 branch May 21, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants