feat(debug): Allow blurring video background during calls [WPB-724] #17326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #17326 +/- ##
==========================================
- Coverage 46.29% 46.13% -0.17%
==========================================
Files 758 760 +2
Lines 24904 25016 +112
Branches 5714 5721 +7
==========================================
+ Hits 11530 11541 +11
- Misses 11931 12033 +102
+ Partials 1443 1442 -1 |
atomrc
changed the title
aweiss-dev
commented
Jun 11, 2024
package.json
Outdated
| @@ -49,10 +50,12 @@ | |||
| "redux-logdown": "1.0.4", | |||
| "redux-thunk": "3.1.0", | |||
| "speakingurl": "14.0.1", | |||
| "stackblur-canvas": "^2.7.0", | |||
.husky/post-checkout
Outdated
There was a problem hiding this comment.
no need for LFS without the large file
.husky/post-commit
Outdated
There was a problem hiding this comment.
no need for LFS without the large file
.husky/post-merge
Outdated
There was a problem hiding this comment.
no need for LFS without the large file
.husky/pre-push
Outdated
There was a problem hiding this comment.
no need for LFS without the large file
.gitattributes
Outdated
| @@ -13,3 +11,4 @@ | |||
| *.ttf binary | |||
| *.woff binary | |||
| *.woff2 binary | |||
| *.tflite filter=lfs diff=lfs merge=lfs -text | |||
There was a problem hiding this comment.
no need for LFS without the large file
|
PatrykBuniX
approved these changes
Jun 11, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a first MVP for the blurred background.
It enabled blurring the self background using a debug util
wire.debug.enableCameraBlur().Next iteration:
Performances
Currently the performances are not quite there yet. The blurring is quite costly.
This is a typical example of the computation of a single frame of the video feed
We can see that the segmentation is taking very little time (some 2-3ms) but blurring takes 20ms+. Since we are supposed to have a budget of 16ms, this is not really our target performance.
It's also quite intense on the main thread and leaves very little resources for the user. Those issues will need to be tackled.
Attempted optimizations
Using webWorker to compute the blur:
Using webgl to compute blurring on the GPU