Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n italian translation completed in all parts #136

Open
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

ginopc
Copy link

@ginopc ginopc commented Oct 25, 2017

No description provided.

i18n italian translation completed! A lot of work...
@@ -31,3 +31,4 @@
- [yous](https://github.com/yous)
- [marocchino](https://github.com/marocchino)
- [MJayJang](https://github.com/MJayJang)
- [ginopc](https://github.com/ginopc)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know, collaborators refer to someone who already have some contributions to the project and have commit access to the repository.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I will collaborator after my pull request is approved?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, once your pull request is approved you become a contributor to the repository. And you will appear into contributors list

I'm not totally sure what criteria was used to add someone into this file, so I prefer left just original maintainers to modify for now.

@ccarruitero
Copy link
Contributor

ccarruitero commented Nov 11, 2019

Aside other minor comment, just prefer to squash commits before merge.

I don't speak italian, so still need someone review translations.

Copy link
Author

@ginopc ginopc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm review all changes

Copy link
Author

@ginopc ginopc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged all changes

@watilde
Copy link
Member

watilde commented Sep 17, 2020

Could we possibly have one person who speaks Italian to review? I'd love to support merging this into master once we get one approval from the one at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants