Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

W/feat/decrement points #86

Merged
merged 13 commits into from
Apr 20, 2024
Merged

W/feat/decrement points #86

merged 13 commits into from
Apr 20, 2024

Conversation

winiboya
Copy link
Contributor

Summary of PR

added decrement logic
frontend and integration tests work, having trouble with one function in unit test (bc it requires another test)

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I have tested on the iOS simulator
  • I have made corresponding changes to the documentation

Todos & Follow ups

mina1957
mina1957 requested changes Apr 20, 2024
View reviewed changes
Copy link
Contributor

@mina1957 mina1957 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LastActivityService.js, line 25, added a comment there.

client/src/services/LastActivityService.js Show resolved Hide resolved
client/src/services/LastActivityService.js Show resolved Hide resolved
@mina1957 mina1957 merged commit 99fd358 into main Apr 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mina1957 mina1957 mina1957 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@winiboya @mina1957