fix: decrementing points after no updates in some time #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-467
force-pushed
the
J/fix/decrementing_points
branch
from
33b402c
to
b676910
Compare
mina1957
approved these changes
Apr 22, 2024
| newPoints.studying_points = Math.min(newPoints.studying_points || 0, 22); | ||
|
|
||
| console.log("New Points", newPoints); | ||
| // ensure that no points are non-negative and not over their maxium. if they are, reduce to maximum |
There was a problem hiding this comment.
nice one, was thinking about that actually!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of PR
Fixed the logic to decrement points after the user doesn't update their habit after some time
Fixed minor logic in PointService such setting minimum and maximum points
Checklist before requesting a review
Todos & Follow ups