Fix: shop button should display properly #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aquapineapples
force-pushed
the
T/fix/metrics
branch
2 times, most recently
from
24a73af
to
dd0a61f
Compare
aquapineapples
force-pushed
the
T/fix/metrics
branch
from
dd0a61f
to
0cb5a63
Compare
J-467
approved these changes
Apr 23, 2024
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of PR
Fixed logic on retrieving/using shop button based on metrics. Improved conditional logic and added comments explaining the conditions in coinsButton.js. Also added logic in home.js so that shopButton is only updated once when the home page is initially rendered.
Checklist before requesting a review
Todos & Follow ups