Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allows user to change the background color #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maxwell04-wq
Copy link

No description provided.

Copy link
Member

@seunomonije seunomonije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! You're the first one!

A few notes:

  • Why label this PR "allows user to change the background color"?
  • Rather than creating a new folder in the rot directory of the repo, just add on to the existing structure.

@@ -0,0 +1 @@
This is a random sentence - I guess!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good sentence, but shouldn't it be located in part4-changing_the_code/people/ and not in the root directory of the repository?

@@ -0,0 +1 @@
# Name: Mahnoor Fatima
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look at part4-changing_the_code/printer.py, you'll see where I put my name. Rather than creating a new file in a new directory, all you need to do is add to the existing file!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants