fix: enum的項目にはチェックリストではなくラベルを使う #14
Merged
+63
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygkn
reviewed
May 17, 2024
Comment on lines
35
to
38
| - Review Lv2: しっかり目を通す | ||
| - description: 「仕様レベルまで理解して、コードレビューする」 | ||
| - Review Lv3: ローカルで動作確認する | ||
| - description: 「仕様レベルまで理解して、コードレビュー・動作確認する」 |
There was a problem hiding this comment.
「動作確認」と「仕様理解」は別の軸なので、ラベルを分けて複数登録するようにしてもよいかもしれません
There was a problem hiding this comment.
複数の「観点」をレーベルで指定する方向に変えてみました！
|
@ygkn 文言の修正をしました！再レビューお願いします 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yumemi-inc/frontend-github-templates#6
個々のPR, Issue が持つ enum 的な属性は、チェックリストではなくラベル機能を使うべきなので、そのように修正しました。