twitter: remove requirement of two internal file and support multiple searches and users #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… searches, users Fixes zulip#697.
timabbott
reviewed
Jun 29, 2021
| @@ -43,7 +44,7 @@ that will process tweets every 5 minutes is: | |||
|
|
|||
| == Setting up Twitter authentications == | |||
|
|
|||
| Run this on a personal or trusted machine, because your API key is | |||
| Run this on a personal or trusted machine, because your APIx key is | |||
There was a problem hiding this comment.
This is presumably a typo.
There was a problem hiding this comment.
Yes it is.
I will remove the x again.
Thanks
timabbott
reviewed
Jun 29, 2021
| elif opts.twitter_name: | ||
| client_type = "ZulipTwitter/" | ||
| CONFIGFILE_INTERNAL = os.path.expanduser("~/.zulip_twitteruserrc_fetchuser") | ||
| SINCE_ID_NAME = "since_id_name_" + opts.twitter_name |
There was a problem hiding this comment.
I was trying to think of a better way to serialize the parameters to a particular instances of the bot, but didn't come up with anything great. One idea would be to have the configuration file support having a block for each search, and use the names defined there. E.g.
[twitter_search_foo]
search_terms = ...
[twitter_search_bar]
twitter_name = ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the necessity to have to internal config files in twitterbot, by using different keys for searches and twitter_names in the same file.
This does also fix #697 in the same way.
See https://chat.zulip.org/#narrow/stream/127-integrations/topic/Twitter/near/1198859 for discussions.
As I do not have access to the Twitter API I could not test this PR.
I could see an possible error at
as search_terms (or twitter_name) contains special characters like
,or@