Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homa nominate validators #2734

Merged
merged 13 commits into from
May 21, 2024
Merged

Homa nominate validators #2734

merged 13 commits into from
May 21, 2024

Conversation

wangjj9219
Copy link
Member

No description provided.

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 70.54264% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 65.18%. Comparing base (16f147e) to head (0eae6d4).

Files Patch % Lines
modules/xcm-interface/src/lib.rs 0.00% 13 Missing ⚠️
modules/homa/src/lib.rs 72.41% 8 Missing ⚠️
modules/homa-validator-list/src/lib.rs 53.33% 7 Missing ⚠️
modules/relaychain/src/lib.rs 20.00% 4 Missing ⚠️
modules/support/src/lib.rs 0.00% 4 Missing ⚠️
modules/nominees-election/src/lib.rs 96.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2734      +/-   ##
==========================================
- Coverage   65.35%   65.18%   -0.18%     
==========================================
  Files          69       67       -2     
  Lines        9808     9018     -790     
==========================================
- Hits         6410     5878     -532     
+ Misses       3398     3140     -258     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangjj9219 wangjj9219 changed the title [WIP]Homa nominate validators Homa nominate validators Apr 14, 2024
@wangjj9219 wangjj9219 marked this pull request as ready for review April 15, 2024 17:27
@xlc xlc requested a review from zjb0807 April 16, 2024 01:52
runtime/common/src/precompile/mock.rs Outdated Show resolved Hide resolved
runtime/karura/src/lib.rs Outdated Show resolved Hide resolved
zjb0807
zjb0807 previously approved these changes Apr 17, 2024
Copy link
Member

@xlc xlc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also integrate with nominees-election to allow LDOT holders to elect validators

runtime/acala/src/lib.rs Outdated Show resolved Hide resolved
runtime/acala/src/lib.rs Outdated Show resolved Hide resolved
runtime/acala/src/lib.rs Outdated Show resolved Hide resolved
runtime/acala/src/lib.rs Outdated Show resolved Hide resolved
@wangjj9219
Copy link
Member Author

should also integrate with nominees-election to allow LDOT holders to elect validators

reviewed the designs of nominee-election and homa-validator-list. They are similar. It seems that nominee-election is an earlier design. Later, there was the pallet homa-validator-list. Similarly, LDOT holders can give validators Votes to increase its guarantee, and the locked guarantee can be frozen and slashed through governance

Need to confirm, is the design of homa-validator-list enough to replace nominee-election? Does it need optimization, or some renaming?

@xlc
Copy link
Member

xlc commented Apr 19, 2024

This is the intended usage:

Validators what wish to become LDOT validators needs to register themselves using homa-validator-list and provide insurance deposit.

Then LDOT holders can nominate LDOT validators using nominee-election to pick the top X validators out of all registered validators from homa-validator-list

So the deposit for homa-validator-list can be low as they have to be top X picked by LDOT holders anyway

@wangjj9219
Copy link
Member Author

This is the intended usage:

Validators what wish to become LDOT validators needs to register themselves using homa-validator-list and provide insurance deposit.

Then LDOT holders can nominate LDOT validators using nominee-election to pick the top X validators out of all registered validators from homa-validator-list

So the deposit for homa-validator-list can be low as they have to be top X picked by LDOT holders anyway

I understand, homa-validator-list serves as a filter, and the pick up logic should be placed in nominee-election, and homa read nominee from nominee-election.

@wangjj9219 wangjj9219 requested a review from xlc April 25, 2024 05:26
runtime/karura/src/lib.rs Outdated Show resolved Hide resolved
runtime/acala/src/lib.rs Outdated Show resolved Hide resolved
runtime/karura/src/lib.rs Outdated Show resolved Hide resolved
xlc
xlc previously approved these changes Apr 30, 2024
@xlc xlc merged commit 49679b7 into master May 21, 2024
6 checks passed
@xlc xlc deleted the homa-nominate-validators-by-xcm branch May 21, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants