Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Selfdestruct after Cancun Upgrade + Fix typos #711

Merged
merged 8 commits into from May 12, 2024

Conversation

jes16jupyter
Copy link
Contributor

@jes16jupyter jes16jupyter commented Apr 15, 2024

What type of PR is this (这是什么类型的PR)

  • Typo(勘误)
  • BUG(程序错误)
  • Improvement(提升)
  • Feature(新特性)

Which issue(s) this PR fixes(Optional) (这个PR 修复了什么问题 (可选择))

  • resolve(修复) : #

What this PR does / why we need it (这个PR 做了什么/ 我们为什么需要这个PR)

  1. Update self-destruct since it is changed in Cancun upgrade. (更新坎昆升级给self-destruct的改动)
  2. Update problems I encounter when learning Library Contract. (解决在学习库合约时遇到的问题)
  3. Update potential security issues - permit front-running. (更新通过抢跑permit操作导致合约相关函数DOS)
  4. Update protection on front-run in contract side (更新在合约测如何应对抢跑问题:设置滑点)
  5. Update how to deal with RO reentrancy (更新如何处理只读重入的问题)

@jes16jupyter jes16jupyter changed the title Update on Library, Self-destruct, ERC20Permit, Front-run, read-only Reentrancy Update Selfdestruct after Cancun Upgrade + Fix typos Apr 17, 2024
@jes16jupyter
Copy link
Contributor Author

@AmazingAng A大看看这个,self-destruct用法更新了。

@AmazingAng
Copy link
Owner

好 最近一直在忙eth beijing黑客松 基本忙完了
明天下午3点 搞个会议审核pr 有空的话一起来

0xAA 邀请您参加腾讯会议
会议主题:WTF PR审核
会议时间:2024/05/12 15:00-16:00 (GMT+08:00) 中国标准时间 - 北京

#腾讯会议:367-976-549

@AmazingAng
Copy link
Owner

很棒的pr
lgtm

@AmazingAng AmazingAng merged commit fcb1a14 into AmazingAng:main May 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants