Upgrades BAP to janestreet v0.16.0 libraries #1602
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmourad01
force-pushed
the
upgrade-janestreet-16
branch
from
6a873d1
to
c172d62
Compare
|
@ivg pinging just to make you aware of this |
ivg
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1589
This is here as a placeholder for now in case we want to upgrade to v0.16.0 version of
base,core,core_kernel, and other related libraries.Several interfaces have been changed/broken as far as I can see, namely:
X.Set,X.Map, andX.Tablehave been gutted of various functions that are present inSet,Map, andHashtbl, respectivelySkipandYieldconstructors forSequence.Step.teach expect an inline record for their arguments.Binable.Of_binable,Binable.Of_stringable, andBin_prot.Make_binableare gone and now have{with,without}_uuidand other variants. Thewithout_uuidis marked as "legacy" in the compiler warnings, stating thatwith_uuidis preferred. I'm leaving it as the former for now as it doesn't require us to change anything else for these functor applications.Camlis now deprecated in favor ofStdlibRight now some of the PowerPC unit tests are failing on my end, so I will try to investigate later when I have time (actually, it seems that they are failing without this change. I'm not sure if this is due to a change in newer versions of LLVM or something else).See #1603, can be merged independently.