Replace newer tr command syntax with older ascii specific operations #1343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For busybox support, some commands don't support the newer syntax :alnum: :cntrl: etc options.
I replaced them with the older counterparts and in one case replaced upper->lower lower->upper with
awk
replacements.Only issue I can see if we are allowing for LOCALE specific optimizations for using
tr
with the posix callbacks. I suspect we aren't since in thegrep
statement on line 71 we use the ASCII syntax of a-z.So I believe this patch will preserve functionality for all platforms, but if there is concerns on still using :alnum: I can submit revised patch where I check if the
tr
command supports advanced functionality and then everytime thetr
command is about to run put an if statement. I thought this would be klunky given how many uses oftr
The test for
tr
functionality is like this: