Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make GH Actions consistent with Sodium's #305

Open
wants to merge 1 commit into
base: 1.17.x/dev
Choose a base branch
from

Conversation

Crackers0106
Copy link

Noticed while updating to the latest dev builds of Lithium and Sodium that the artifacts produced were different, such as Sodium's naming for the build artifacts file being sodium-artifacts-(branch name) and only including the Minecraft compatible jar file.

Ideally, it feels like these should be pretty much the same between the three mods, and could make it easier to tell which file has which artifacts inside if you have a dozen files named build-artifacts.zip downloaded with no way to tell what they're for without checking inside them like I do.

This is my first PR, so I hope I'm doing this right

@2No2Name
Copy link
Member

2No2Name commented Dec 7, 2021

    # Filter built files to disregard -sources and -dev, and leave only the minecraft-compatible jars.
    path: build/libs/*[0-9].jar

Doesn't seem to work

@2No2Name
Copy link
Member

2No2Name commented Dec 8, 2021

This clearly happens because lithium uses a different jar naming system. Changing to sodiums naming system might be a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants