-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: aggregate with randomness #139
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewkeil
force-pushed
the
mkeil/aggregate-with-randomness
branch
from
April 29, 2024 05:51
3ef1c8b
to
6539f39
Compare
matthewkeil
changed the title
Mkeil/aggregate with randomness
feat: aggregate with randomness
Apr 29, 2024
wemeetagain
reviewed
Apr 29, 2024
matthewkeil
force-pushed
the
mkeil/aggregate-with-randomness
branch
from
April 29, 2024 13:21
6539f39
to
6b99da1
Compare
Performance Report✔️ no performance regression detected Full benchmark results
|
matthewkeil
force-pushed
the
mkeil/aggregate-with-randomness
branch
from
May 9, 2024 13:25
9fcfe35
to
ccc1a7f
Compare
matthewkeil
force-pushed
the
mkeil/fix-spec-tests
branch
from
May 22, 2024 13:11
36c3b1b
to
3aa164e
Compare
matthewkeil
force-pushed
the
mkeil/aggregate-with-randomness
branch
from
May 23, 2024 13:52
43d1a69
to
e61571b
Compare
matthewkeil
force-pushed
the
mkeil/aggregate-with-randomness
branch
from
May 23, 2024 14:25
e61571b
to
8f359cb
Compare
wemeetagain
reviewed
May 23, 2024
LesnyRumcajs
approved these changes
May 23, 2024
wemeetagain
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR is based on code in #144, #145, #146. Need to update merge branch to
master
once those PR's are merged. Do not merge until that happens but is ready for review** Motivation **
Aggregation of signatures in lodestar can take up to 25% of cpu thread time. The process includes a lot of generated JS objects that immediately get thrown away once the signatures are aggregated. This PR is designed to create a single signature call that will do the deserialization and aggregation, with added randomness, in a single function call. By moving this to native the JS objects do not need to be created so only the native deserialization is necessary. Created an async version as well to move this time-intensive work to the worker pool.
** Description of Inclusions **
aggregateWithRandomness
andasyncAggregateWithRandomness
functions and unit testsaggregateWithRandomness
getTestSetsSameMessage
andSameMessageTestSets
type