Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hosted snapshots should include their respective hashes #370

Open
1 of 3 tasks
LesnyRumcajs opened this issue Jan 9, 2024 · 2 comments
Open
1 of 3 tasks

Hosted snapshots should include their respective hashes #370

LesnyRumcajs opened this issue Jan 9, 2024 · 2 comments
Assignees
Labels
daily-snapshot Issues related to the daily snapshot service

Comments

@LesnyRumcajs
Copy link
Member

LesnyRumcajs commented Jan 9, 2024

Issue summary

This is an umbrella issue for all snapshots hosted in Cloudflare. If someone downloads 20 TiB worth of snapshots, they should be able to verify successful and correct download via digests.

This includes:

  • Lite snapshots (and their automatic generation, once it happens),
  • Diff snapshots (and their automatic generation, once it happens),
  • Latest snapshots

For both mainnet and calibration network.

The standard approach is to use sha256sum. Unless something has changed, Forest can generate the checksum file independently when exporting a snapshot. I'm not sure what the status of this feature outside of the export command is.

Other information and links

@LesnyRumcajs LesnyRumcajs added the daily-snapshot Issues related to the daily snapshot service label Jan 15, 2024
@samuelarogbonlo
Copy link
Contributor

@LesnyRumcajs, my proposed solution is to write a one off script will download or regenerate the current snapshots (both lite and diff), create a shasum file for them, and upload everything to R2. After that, we can update this when @sudo-shashank is done to include the SHA sum in the process of generating and uploading archival snapshots. For the latest snapshot, we can update the snapshot service to also generate shasums and upload.

Question: should we update the Cf code to also download the shasum when the snapshot link is hit

@LesnyRumcajs
Copy link
Member Author

LesnyRumcajs commented May 7, 2024

  1. It's not needed to download the lite and diff snapshots (at least most of them) - they are in majority on archie.
  2. What's the point of regenerating the snapshots? The snapshots won't change, so only corresponding shasum files need to be uploaded.

Question: should we update the Cf code to also download the shasum when the snapshot link is hit

No. The vast majority of people won't use them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
daily-snapshot Issues related to the daily snapshot service
Projects
None yet
Development

No branches or pull requests

2 participants