Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upload corresponding latest snapshot sha256sum #441

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

samuelarogbonlo
Copy link
Contributor

@samuelarogbonlo samuelarogbonlo commented May 8, 2024

Summary of changes
Changes introduced in this pull request:

  • upload corresponding latest snapshot sha256sum

Reference issue to close (if applicable)

part #370

Other information and links

Signed-off-by: samuelarogbonlo <sbayo971@gmail.com>
@samuelarogbonlo samuelarogbonlo requested a review from a team as a code owner May 8, 2024 11:01
@samuelarogbonlo samuelarogbonlo requested review from hanabi1224 and LesnyRumcajs and removed request for a team May 8, 2024 11:01
@samuelarogbonlo samuelarogbonlo changed the title fix: upload corresponding latest snapshot fix: upload corresponding sha256sum latest snapshot May 9, 2024
@samuelarogbonlo samuelarogbonlo changed the title fix: upload corresponding sha256sum latest snapshot fix: upload corresponding latest snapshot sha256sum May 9, 2024
Copy link
Collaborator

@lemmih lemmih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's enumerate the files to be uploaded rather than using a wildcard.

Signed-off-by: samuelarogbonlo <sbayo971@gmail.com>
@samuelarogbonlo
Copy link
Contributor Author

Let's enumerate the files to be uploaded rather than using a wildcard.

updated, @lemmih what do you think ?

@lemmih
Copy link
Collaborator

lemmih commented May 14, 2024

Let's enumerate the files to be uploaded rather than using a wildcard.

updated, @lemmih what do you think ?

You're still using a wildcard rather than enumerating the files. We only want to upload the archive and checksum files. Any other files in that directory should not be uploaded.

@LesnyRumcajs
Copy link
Member

@lemmih Looking at https://github.com/ChainSafe/forest-iac/blob/main/cf/prune-latest/src/index.ts, it seems that adding corresponding checksum files would decrease the number of recent snapshots by half. Are we okay with that? Or should that worker be updated accordingly?

@lemmih
Copy link
Collaborator

lemmih commented May 14, 2024

@lemmih Looking at https://github.com/ChainSafe/forest-iac/blob/main/cf/prune-latest/src/index.ts, it seems that adding corresponding checksum files would decrease the number of recent snapshots by half. Are we okay with that? Or should that worker be updated accordingly?

If the Infra team is ready to take over then we don't have to worry about retention. Let's see what Josh at the meeting later today. If they need more time, we'll bump our retention (which is still quite a bit lower than required by the contract, iirc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants