Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ApiHeadChange type #4276

Closed
wants to merge 14 commits into from
Closed

Fix ApiHeadChange type #4276

wants to merge 14 commits into from

Conversation

elmattic
Copy link
Contributor

@elmattic elmattic commented Apr 30, 2024 •
edited

Summary of changes

Changes introduced in this pull request:

  • Fix api type
  • Add a way of testing subscription method

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@elmattic elmattic marked this pull request as ready for review May 6, 2024 13:28
@elmattic elmattic requested a review from a team as a code owner May 6, 2024 13:28
@elmattic elmattic requested review from lemmih and sudo-shashank and removed request for a team May 6, 2024 13:28
@elmattic elmattic marked this pull request as draft May 6, 2024 16:03
@elmattic
Copy link
Contributor Author

elmattic commented Jun 5, 2024

Closing because superseded by #4357

@elmattic elmattic closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemmih lemmih Awaiting requested review from lemmih lemmih is a code owner automatically assigned from ChainSafe/forest

@sudo-shashank sudo-shashank Awaiting requested review from sudo-shashank sudo-shashank is a code owner automatically assigned from ChainSafe/forest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@elmattic