feat(dot/parachain): Implement candidate validation subsystem skeleton #3916

edwardmack · 2024-04-23T20:33:07Z

Changes

Create CandidateValidation struct
Implement stubs for interface 'dot/parachain/types/Subsystem`
Implement register candidate validation subsystem with overseer
Create skeleton structs for candidate validation messages: `ValidateFromChainState', 'ValidateFromExhaustive' and 'PreCheck'
Implement overseer forward message functionality.
move existing logic and test to 'candidvalidation' package
Noted TODO lines in code where additional functionality is to be implemented. (TODO: create issues for these)

Tests

 go test github.com/ChainSafe/gossamer/dot/parachain/candidate-validation

Issues

closes #3586

Primary Reviewer

@kishansagathiya @axaysagathiya

dot/parachain/candidate-validation/candidate_validation.go

dot/parachain/candidate-validation/register.go

dot/parachain/collator-protocol/validator_side.go

dot/parachain/overseer/types.go

dot/parachain/candidate-validation/candidate_validation.go

dot/parachain/candidate-validation/messages.go

dot/parachain/candidate-validation/candidate_validation.go

…ructs

dot/parachain/candidate-validation/candidate_validation.go

dot/parachain/candidate-validation/mocks_runtime_test.go

dot/parachain/candidate-validation/mocks_test.go

dot/parachain/candidate-validation/register.go

dot/parachain/candidate-validation/messages.go

dot/parachain/candidate-validation/candidate_validation.go

dot/parachain/candidate-validation/messages.go

dot/parachain/candidate-validation/candidate_validation.go

axaysagathiya

LGTM!

edwardmack self-assigned this Apr 23, 2024

edwardmack force-pushed the ed/feat/candidate_validation_skeleton branch 2 times, most recently from 215c59f to 2e5e252 Compare May 1, 2024 14:23

edwardmack marked this pull request as ready for review May 1, 2024 15:18

edwardmack requested review from timwu20, EclesioMeloJunior, jimjbrettj, kishansagathiya, dimartiro and axaysagathiya as code owners May 1, 2024 15:18

edwardmack commented May 1, 2024

View reviewed changes

dot/parachain/candidate-validation/candidate_validation.go Outdated Show resolved Hide resolved

EclesioMeloJunior requested changes May 6, 2024

View reviewed changes

dot/parachain/candidate-validation/register.go Outdated Show resolved Hide resolved

dot/parachain/collator-protocol/validator_side.go Outdated Show resolved Hide resolved

dot/parachain/overseer/types.go Outdated Show resolved Hide resolved

kishansagathiya reviewed May 6, 2024

View reviewed changes

dot/parachain/candidate-validation/candidate_validation.go Outdated Show resolved Hide resolved

dot/parachain/candidate-validation/candidate_validation.go Outdated Show resolved Hide resolved

kishansagathiya reviewed May 7, 2024

View reviewed changes

dot/parachain/candidate-validation/candidate_validation.go Show resolved Hide resolved

dot/parachain/candidate-validation/messages.go Outdated Show resolved Hide resolved

kishansagathiya reviewed May 7, 2024

View reviewed changes

dot/parachain/candidate-validation/candidate_validation.go Outdated Show resolved Hide resolved

edwardmack marked this pull request as draft May 14, 2024 14:04

edwardmack added 10 commits May 14, 2024 15:01

create stubs to implement Subsystem interface

a97e182

create message types, move existing code to candidatevalidation package

e91fc57

fix rebase conflicts

3c602a0

address rebase conflicts

8c09246

address rebase conflicts

72a9da9

add issue numbers to TODOs

6592e55

added test wasm file

bc0d3ca

address PR comments

573adc8

call validateFromChainState in processMessages

056134d

fix merge conflicts

4d82c4c

edwardmack force-pushed the ed/feat/candidate_validation_skeleton branch from 4ae78db to 4d82c4c Compare May 15, 2024 22:10

remove context from candidate validation subsystem, create message st…

67a7efd

…ructs

edwardmack marked this pull request as ready for review May 17, 2024 21:48

edwardmack requested a review from kishansagathiya May 17, 2024 21:48

edwardmack requested a review from EclesioMeloJunior May 17, 2024 21:48

Merge branch 'feat/parachain' into ed/feat/candidate_validation_skeleton

19163ba

timwu20 reviewed May 23, 2024

View reviewed changes

dot/parachain/candidate-validation/candidate_validation.go Outdated Show resolved Hide resolved

dot/parachain/candidate-validation/candidate_validation.go Show resolved Hide resolved

close stop channel in stop function

346810b

edwardmack requested a review from timwu20 May 23, 2024 13:21

timwu20 removed request for dimartiro, EclesioMeloJunior and jimjbrettj May 23, 2024 18:56

axaysagathiya reviewed May 24, 2024

View reviewed changes

address PR comments, remove redundant structs, cleanup

ae17416

axaysagathiya reviewed May 25, 2024

View reviewed changes

edwardmack added 2 commits May 28, 2024 11:33

address PR comments, remove not needed structs

3e0b885

remove un-used parameters in functions

bb9f017

edwardmack requested review from axaysagathiya and EclesioMeloJunior May 28, 2024 19:22

axaysagathiya approved these changes May 29, 2024

View reviewed changes

EclesioMeloJunior approved these changes May 29, 2024

View reviewed changes

edwardmack merged commit ff28c9f into feat/parachain May 29, 2024
21 checks passed

edwardmack deleted the ed/feat/candidate_validation_skeleton branch May 29, 2024 13:26

edwardmack mentioned this pull request May 29, 2024

Reconsider methods defined by the Subsystem interface #3989

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(dot/parachain): Implement candidate validation subsystem skeleton #3916

feat(dot/parachain): Implement candidate validation subsystem skeleton #3916

edwardmack commented Apr 23, 2024

axaysagathiya left a comment

feat(dot/parachain): Implement candidate validation subsystem skeleton #3916

feat(dot/parachain): Implement candidate validation subsystem skeleton #3916

Conversation

edwardmack commented Apr 23, 2024

Changes

Tests

Issues

Primary Reviewer

axaysagathiya left a comment

Choose a reason for hiding this comment