Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(internal/client/state-db): noncanonical overlays to support unfinalized changes #3951

Merged
merged 8 commits into from
May 28, 2024
Merged

feat(internal/client/state-db): noncanonical overlays to support unfinalized changes #3951

merged 8 commits into from
May 28, 2024

Conversation

timwu20
Copy link
Contributor

@timwu20 timwu20 commented May 14, 2024 •
edited

Changes

  • NonCanonicalOverlay maintains trees of block overlays and allows discarding trees/roots.
  • The overlays are added in Insert and removed in Canonicalize.
  • Introduces hash.H256 type under internal/primitives/core/hash.
  • Tests for overlays.

Tests

go test -tags integration github.com/ChainSafe/gossamer/internal/client/state-db

Issues

Primary Reviewer

@dimartiro

@timwu20 timwu20 marked this pull request as ready for review May 14, 2024 02:30
@timwu20 timwu20 changed the title feat(internal/client/state-db): Noncanonical Overlays to support non canonicalized changes feat(internal/client/state-db): non-canonical overlays to support non-canonicalized changes May 14, 2024
@timwu20 timwu20 changed the title feat(internal/client/state-db): non-canonical overlays to support non-canonicalized changes feat(internal/client/state-db): noncanonical overlays to support unfinalized changes May 14, 2024
dimartiro
dimartiro requested changes May 15, 2024
View reviewed changes
internal/client/state-db/statedb.go Outdated Show resolved Hide resolved
internal/client/state-db/statedb.go Outdated Show resolved Hide resolved
internal/client/state-db/statedb.go Show resolved Hide resolved
internal/client/state-db/statedb.go Show resolved Hide resolved
internal/client/state-db/noncanonical.go Outdated Show resolved Hide resolved
internal/client/state-db/noncanonical.go Show resolved Hide resolved
internal/client/state-db/noncanonical.go Outdated Show resolved Hide resolved
internal/client/state-db/noncanonical.go Outdated Show resolved Hide resolved
internal/primitives/core/hash/hash.go Show resolved Hide resolved
@dimartiro dimartiro assigned dimartiro and unassigned dimartiro May 20, 2024
@timwu20 timwu20 requested a review from dimartiro May 21, 2024 01:20
@timwu20 timwu20 requested a review from P1sar as a code owner May 24, 2024 02:33
@timwu20 timwu20 changed the base branch from development to refactor/client-db May 24, 2024 02:35
@timwu20 timwu20 removed the request for review from P1sar May 24, 2024 02:35
@timwu20 timwu20 merged commit 3b81b1c into refactor/client-db May 28, 2024
23 of 24 checks passed
@timwu20 timwu20 deleted the tim/state-db branch May 28, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimartiro dimartiro dimartiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timwu20 @dimartiro