feat: generalize blobs to data for extension ready for ils and/or data columns #6693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
…a columns rename types and fix references to them update forkchoice and availability flow propagate changes to the codebase lint and tsc some fixes cleanup test run fixes fix the tests fix
twoeths
reviewed
Jun 10, 2024
| function notOnOutOfRangeData(beaconBlockRoot: Root): void { | ||
| const protoBeaconBlock = chain.forkChoice.getBlock(beaconBlockRoot); | ||
| if (!protoBeaconBlock) { | ||
| throw new ApiError(400, "Block not in forkChoice"); |
There was a problem hiding this comment.
add beaconBlockRoot to error message
twoeths
reviewed
Jun 10, 2024
| }; | ||
| }, | ||
|
|
||
| outOfRangeData( |
There was a problem hiding this comment.
when is a block "out of range data"?
twoeths
reviewed
Jun 10, 2024
| }; | ||
| type Availability<T> = {availabilityPromise: Promise<T>; resolveAvailability: (data: T) => void}; | ||
|
|
||
| type CachedBlobs = BlobsInputCache & Availability<BlockInputDataBlobs>; |
There was a problem hiding this comment.
having both CachedBlobs and BlobsCache types seems confusing
twoeths
reviewed
Jun 10, 2024
| preDeneb = "preDeneb", | ||
| postDeneb = "postDeneb", | ||
| blobsPromise = "blobsPromise", | ||
| preData = "preData", |
There was a problem hiding this comment.
drop a comment to note this also means pre deneb
|
a note for reviewers, this PR also adds a new field "dataAvailabilityStatus" to forkchoice |
twoeths
reviewed
Jun 10, 2024
| @@ -136,33 +136,29 @@ export class SeenGossipBlockInput { | |||
|
|
|||
| if (blobKzgCommitments.length === blobsCache.size) { | |||
| const allBlobs = getBlockInputBlobs(blobsCache); | |||
| resolveAvailability({...allBlobs, blobsSource: BlobsSource.gossip}); | |||
| const blockData = {...allBlobs, blobsSource: BlobsSource.gossip, fork: cachedData.fork} as BlockInputDataBlobs; | |||
There was a problem hiding this comment.
do we need to enhance type to avoid type. cast?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid redoing the same work on different branches and have a clean way to extend data requirements