-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dual export some modules (params, utils, test-utils, spec-test-util) #6733
Draft
matthewkeil
wants to merge
3
commits into
unstable
Choose a base branch
from
mkeil/dual-export-spec-test-util
base: unstable
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected 🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
matthewkeil
force-pushed
the
mkeil/dual-export-spec-test-util
branch
from
May 6, 2024 12:46
0e36a08
to
d765e83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I updated the spec tests in blst-ts and the util in lodestar is much better. Need a CJS module though to be able to import it there. Dual-module export of
spec-test-util
depends onutils
so update that one as well. There are some good othertest-utils
that may be helpful in other repos and the script was already written so exported that as well. That depends onparams
so updated that also. Sets a pretty good precedent for how we can export packages as dual module should we want to.Description
scripts/fix_dual_modules_lib.mjs
scripts/fix_dirname_and_filename.mjs
tsconfig.build.json
totsconfig.esm.json
for all dual module packagestsconfig.cjs.json
to all dual module packages