fix: get seen AttData key from SignedAggregateAndProof electra #6802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarhussain
approved these changes
May 17, 2024
wemeetagain
approved these changes
May 17, 2024
nflaig
requested changes
May 17, 2024
twoeths
force-pushed
the
te/getSeenAttDataKeyFromSignedAggregateAndProofElectra
branch
from
ac22e53
to
9b003aa
Compare
nflaig
approved these changes
May 17, 2024
twoeths
deleted the
te/getSeenAttDataKeyFromSignedAggregateAndProofElectra
branch
g11tech
pushed a commit
that referenced
this pull request
May 24, 2024
* fix: get seen AttData key from SignedAggregateAndProof electra * chore: revert the naming change to COMMITTEE_BITS_SIZE and add comment * fix: add toBase64() util
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Our AggregateAndProof gossip validation was getting worse in electra devnet-0
Description
It never hit the cache since we get the wrong Attestation Data key.