Sygma Client implementation. #923

kantagara · 2024-04-12T15:38:27Z

FINALLY sygma works.
IT took a LOT of time to make it work.

One very very important note: I am pretty sure that for all of you the Erc1155 will fail to execute. You'd need to own some 1155 with a specific tokenId on Sepolia, and then you can test it out. Chain Id is set to Cronos.

Guide to test:

Own some token for 1155
In SampleMain, go to Category - Sygma
There is sygma client script attached to it
Adjust tokenId, other things should remain as is I'd say
If everything works you can check the transaction by going to
https://sepolia.etherscan.io/tx/TRANSACTION_HASH
Where TRANSACTION_HASH is the hash that got spit out as output from SygmaClient-SendTransaction

ANOTHER NOTE:
I did update Countly on this branch by accident, so just ignore everything Countly related.

…late this.

…e to come.

boorich · 2024-04-15T06:14:05Z

This is great!

juans-chainsafe

Some updates:
The flow is working correctly in our side right now, I tested in the editor with wallet connect in Metamask and in WebGL with Metamask login.

But there is a issue in Sygma side right now that causes the transfer to not go through.
I will test the complete flow when thats fixed.

FYI: something weird that Im not sure if is in our side or Sygma, the approve to access the tokens inside the collection should happen only once (if that collection was approved before), otherwise we are spending extra gas fees on that every time https://sepolia.etherscan.io/tx/0x9143b7d169f8c899012f66828bbe1fe7c41518dc50bd4a0d30121e7a41e3d07f cc @kantagara if is on our side, we can have a separate ticket for this

juans-chainsafe

Functionality is working if you provide the specific data to use it, but for a final user is not practical.

A final version will need:

Approve only 1 time per collection and not in all transactions
A log for the user to know where he can find the token in the new chain or the transaction hash in that chain
Be able to select which tokens I want to transfer
Should work with any ERC-1155 tokens and not only the ones that Sygma send to us

But this implementation is a big step and a great functionality to have! Congrats

oleksandrchainsafe

Left a couple of comments

oleksandrchainsafe · 2024-04-22T10:05:58Z

src/ChainSafe.Gaming.SygmaClient/Contracts/BasicFeeHandler.cs

@@ -19,22 +20,23 @@ public class BasicFeeHandler : IBasicHandler
        public BasicFeeHandler(IContractBuilder cb, string address)
        {
            this.address = address;
-            this.contract = cb.Build(FeeHandlerAbi, address);
+            contract = cb.Build(FeeHandlerAbi, address);


The FeeHandlerAbi, you can replace the huge constant declared inside the file with an embedded resource. There is an example in the Marketplace project.
There is also a helper method to read ABI from resources. It's called AbiHelper.ReadAbiFromResources.

oleksandrchainsafe · 2024-04-22T10:10:34Z

src/ChainSafe.Gaming.SygmaClient/DepositDataHandlers/SemiFungibleDepositDataHandler.cs

+
+namespace ChainSafe.Gaming.SygmaClient.DepositDataHandlers
+{
+    // Struct so we don't allocate memory on the heap


It's not a struct.

oleksandrchainsafe · 2024-04-22T10:33:18Z

...ampleProject/Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scenes/SampleTransfer.cs

+            throw new Web3Exception("Web3 Instance is not set. Please set it after you've built the Web3 instance.");
+        }
+
+        await Erc20.TransferErc20(Web3Accessor.Web3, Contracts.Erc20, toAddress, System.Numerics.BigInteger.Parse(amount));


Does this sample have anything to do with the Sygma integration?

oleksandrchainsafe · 2024-04-22T10:36:58Z

...ets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/SygmaClient.cs

+
+    private ISygmaClient _sygmaClient;
+    private bool _isSygmaInitialized;
+    private Web3 _web3;


We were using lowercase names without the "_" prefix for private fields before. Let's stick to one style.

oleksandrchainsafe · 2024-04-22T10:40:55Z

...ets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/SygmaClient.cs

+    [field: SerializeField] public uint Amount { get; private set; } = 1;
+}
+
+public class SygmaClient : MonoBehaviour


I would recommend renaming it to avoid confusion around names. This is more like SygmaSample that Client.

oleksandrchainsafe · 2024-04-22T10:42:25Z

...ets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/SygmaClient.cs

+using Environment = ChainSafe.Gaming.SygmaClient.Types.Environment;
+
+[Serializable]
+public class SygmaConfig


We can move all fields right into the sample behaviour, as this is more like SygmaSampleConfig than the actual config of the SygmaClient.

oleksandrchainsafe · 2024-04-22T10:45:07Z

...ets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scripts/Scenes/SampleMain/SygmaClient.cs

+        button.onClick.AddListener(CallSygma);
+        _web3 = Web3Accessor.Web3;
+        _sygmaClient = Web3Accessor.Web3.SygmaClient();
+        _isSygmaInitialized = _sygmaClient.Initialize(sygmaConfig.SygmaEnvironment);


Shouldn't the value of SygmaEnvironment reflect the one for the original (default) chain settings from the server settings window?

rob1997

Nice work! added a few comments, mostly just questions tbh

rob1997 · 2024-04-24T10:34:37Z

...fe.web3-unity.lootboxes/Chainlink/Runtime/Libraries/ChainSafe.Gaming.Lootboxes.Chainlink.dll

We don't need to track these DLLs, they'll be auto committed in dev

Or the DLLs in Packages/io.chainsafe.web3-unity/Runtime/Libraries/

rob1997 · 2024-04-24T10:36:13Z

Packages/io.chainsafe.web3-unity/Runtime/Plugins/Countly SDK.meta

Are these our own edits to the plugin or just an update?

rob1997 · 2024-04-24T10:43:37Z

...leProject/Assets/Samples/web3.unity SDK/2.5.0/Web3.Unity Samples/Scenes/SampleTransfer.unity

Does Sygma necessarily need it's own scene? Can't we add it in a Column in SampleMain?

rob1997 · 2024-04-24T10:44:49Z

src/UnitySampleProject/ProjectSettings/TimelineSettings.asset

We can ignore this, right?

kantagara and others added 12 commits March 8, 2024 15:17

Basic sample with no data. Waiting on Tihomir/Mak to help out to popu…

fedb804

…late this.

SygmaClient Interface update and Demo Scene comment

b83f2de

Fixing some issues when fetching, fixed issue when logging. Still mor…

3eb629f

…e to come.

Fixing (a)sync issues

1db56bb

Updated countly. Contract calls updated as well.

0e731e0

Fixed sygma, fixed countly.

cf28b33

Network name and chain Id should now always be available.

50db9a3

Fixing more sygma-related errors..

67e6612

all methods except one works.

129f0dd

Fixing a lot of issues. Still not done yet.

83cc590

Fixed Sygma not working.

be1113e

Sygma client is now completley abstracted for the end-developer.

1b232ef

auto-assign bot requested review from juans-chainsafe, oleksandrchainsafe, rob1997 and sneakzttv April 12, 2024 15:38

auto-assign bot assigned kantagara Apr 12, 2024

Merge branch 'main' into nikola/sygma-sample

735f828

kantagara added the ready-to-merge Ready to Merge PR - this'll trigger required checks label Apr 12, 2024

Run setup.sh

e709c72

kantagara added ready-to-merge Ready to Merge PR - this'll trigger required checks and removed ready-to-merge Ready to Merge PR - this'll trigger required checks labels Apr 12, 2024

Lint

88e06d6

kantagara added ready-to-merge Ready to Merge PR - this'll trigger required checks and removed ready-to-merge Ready to Merge PR - this'll trigger required checks labels Apr 12, 2024

Linting fix vol2

d6d0a58

kantagara added ready-to-merge Ready to Merge PR - this'll trigger required checks and removed ready-to-merge Ready to Merge PR - this'll trigger required checks labels Apr 12, 2024

erc1155 should now be semifungible

dc7341d

Fixing sygma client issues.

b53a03e

juans-chainsafe reviewed Apr 15, 2024

View reviewed changes

juans-chainsafe approved these changes Apr 18, 2024

View reviewed changes

sneakzttv approved these changes Apr 22, 2024

View reviewed changes

oleksandrchainsafe requested changes Apr 22, 2024

View reviewed changes

rob1997 reviewed Apr 24, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sygma Client implementation. #923

Sygma Client implementation. #923

kantagara commented Apr 12, 2024 •

edited

boorich commented Apr 15, 2024

juans-chainsafe left a comment •

edited

juans-chainsafe left a comment

oleksandrchainsafe left a comment

oleksandrchainsafe Apr 22, 2024

oleksandrchainsafe Apr 22, 2024

oleksandrchainsafe Apr 22, 2024

oleksandrchainsafe Apr 22, 2024

oleksandrchainsafe Apr 22, 2024

oleksandrchainsafe Apr 22, 2024

oleksandrchainsafe Apr 22, 2024

rob1997 left a comment

rob1997 Apr 24, 2024

rob1997 Apr 24, 2024

rob1997 Apr 24, 2024

rob1997 Apr 24, 2024

rob1997 Apr 24, 2024

Sygma Client implementation. #923

Are you sure you want to change the base?

Sygma Client implementation. #923

Conversation

kantagara commented Apr 12, 2024 • edited

boorich commented Apr 15, 2024

juans-chainsafe left a comment • edited

Choose a reason for hiding this comment

juans-chainsafe left a comment

Choose a reason for hiding this comment

oleksandrchainsafe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rob1997 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kantagara commented Apr 12, 2024 •

edited

juans-chainsafe left a comment •

edited