Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UnitySampleProject to 2022 LTS #938

Merged

Conversation

oleksandrchainsafe
Copy link
Contributor

Updated to 2022.3.26f1

@oleksandrchainsafe
Copy link
Contributor Author

@juans-chainsafe Please "Ensure all features are working as before across all platforms"

Copy link
Contributor

@juans-chainsafe juans-chainsafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didnt finish the whole testing, but this is the feedback so far:

  • Editor with web3auth + samples + logout + remember me ✅
  • Editor with wallet connect + samples + logout + remember me ✅
  • Isolated Lootbox scene (without login) in editor ✅
  • WebGL with metamask login + samples + logout ✅

❌ Issues:

  • Ramp is not working in WebGL, neither metamask login or web3auth, loading spinner is stuck in a loop: Screenshot 2024-05-03 at 10 38 29 AM
  • Samples that require sign a transaction like GetNonce, Mint or Transfer in WebGL with web3auth: Screenshot 2024-05-03 at 12 39 12 PM
Invoking error handler due to
RuntimeError: null function or function signature mismatch

Stuff that I can't test due to previous errors:

PENDING:

  • iOS with web3auth
  • iOS with wallet connect
  • Empty Unity project from scratch

@juans-chainsafe
Copy link
Contributor

I didnt finish the whole testing, but this is the feedback so far:

  • Editor with web3auth + samples + logout + remember me ✅
  • Editor with wallet connect + samples + logout + remember me ✅
  • Isolated Lootbox scene (without login) in editor ✅
  • WebGL with metamask login + samples + logout ✅

❌ Issues:

  • Ramp is not working in WebGL, neither metamask login or web3auth, loading spinner is stuck in a loop: Screenshot 2024-05-03 at 10 38 29 AM
  • Samples that require sign a transaction like GetNonce, Mint or Transfer in WebGL with web3auth: Screenshot 2024-05-03 at 12 39 12 PM
Invoking error handler due to
RuntimeError: null function or function signature mismatch

Stuff that I can't test due to previous errors:

PENDING:

  • iOS with web3auth
  • iOS with wallet connect
  • Empty Unity project from scratch

iOS testing:

  • iOS with web3auth + samples + logout + remember me ✅
  • iOS with wallet connect + samples + logout + remember me ✅
  • Ramp ✅

@oleksandrchainsafe weird thing is that Ramp is working in iOS but not in WebGL. And samples that require a transaction works in iOS + web3auth but they DON'T work in WebGL + web3auth

@rob1997
Copy link
Collaborator

rob1997 commented May 8, 2024

I didnt finish the whole testing, but this is the feedback so far:

  • Editor with web3auth + samples + logout + remember me ✅
  • Editor with wallet connect + samples + logout + remember me ✅
  • Isolated Lootbox scene (without login) in editor ✅
  • WebGL with metamask login + samples + logout ✅

❌ Issues:

  • Ramp is not working in WebGL, neither metamask login or web3auth, loading spinner is stuck in a loop: Screenshot 2024-05-03 at 10 38 29 AM
  • Samples that require sign a transaction like GetNonce, Mint or Transfer in WebGL with web3auth: Screenshot 2024-05-03 at 12 39 12 PM
Invoking error handler due to
RuntimeError: null function or function signature mismatch

Stuff that I can't test due to previous errors:

PENDING:

  • iOS with web3auth
  • iOS with wallet connect
  • Empty Unity project from scratch

iOS testing:

  • iOS with web3auth + samples + logout + remember me ✅
  • iOS with wallet connect + samples + logout + remember me ✅
  • Ramp ✅

@oleksandrchainsafe weird thing is that Ramp is working in iOS but not in WebGL. And samples that require a transaction works in iOS + web3auth but they DON'T work in WebGL + web3auth

@juans-chainsafe could you check window -> package manager if WebGL Threading Patcher is installed as such
image

@juans-chainsafe
Copy link
Contributor

juans-chainsafe commented May 10, 2024

Ramp issue on WebGL can be solved by following steps here

Copy link
Contributor

@juans-chainsafe juans-chainsafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WebGL + Web3Auth issue was fixed with #963
So, we are good to go!

@rob1997 rob1997 added the ready-to-merge Ready to Merge PR - this'll trigger required checks label May 17, 2024
@oleksandrchainsafe oleksandrchainsafe merged commit 257071f into dev May 20, 2024
5 checks passed
@oleksandrchainsafe oleksandrchainsafe deleted the oleksandr/update-unitysampleproject-to-2022-lts branch May 20, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to Merge PR - this'll trigger required checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants